K8s CRD definition for Sentinel rules #182
Conversation
louyuting
added
area/data-source
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=======================================
Coverage 44.51% 44.51%
=======================================
Files 78 78
Lines 4315 4315
=======================================
Hits 1921 1921
Misses 2181 2181
Partials 213 213 Continue to review full report at Codecov.
|
| apiVersion: apiextensions.k8s.io/v1 | ||
| kind: CustomResourceDefinition | ||
| metadata: | ||
| name: cbrules.datasource.sentinel.com |
There was a problem hiding this comment.
The abbr might not be clear enough. Maybe cbrules -> circuitbreaker.rules or circuitbreakerrules or other better representation?
There was a problem hiding this comment.
In open-source world we'd like *.sentinel.io (though the domain is not owned by us :(
There was a problem hiding this comment.
I prefer circuitbreaker.rules
| minimum: 0 | ||
| required: | ||
| - resource | ||
| - limitOrigin |
There was a problem hiding this comment.
Only resource, metricType and count are required. For other attributes, we could provide default values.
| - controlBehavior | ||
| - paramIndex | ||
| - threshold | ||
| - maxQueueingTimeMs |
There was a problem hiding this comment.
Please also simplify the required list here.
sczyh30
changed the title
sczyh30
added
area/cloud-native
|
Duplicated #242 |
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews